Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: Use consistent, accurate naming for store keys #14150

Closed
aduth opened this issue Feb 27, 2019 · 0 comments · Fixed by #26655
Closed

Data: Use consistent, accurate naming for store keys #14150

aduth opened this issue Feb 27, 2019 · 0 comments · Fixed by #26655
Labels
[Package] Data /packages/data [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented Feb 27, 2019

Previously:

There are currently at least four naming conventions to refer to the namespace assigned to a registered store.

  1. "reducer key"
  2. "module key"
  3. "store key"
  4. "store name"

We should seek to consolidate this to a single, consistent naming convention. While reducer key was the original naming, it is no longer strictly accurate since a store no longer needs to be implemented as Redux-based (see #10289).

My recommendation would be storeName, merely for alignment with the similarly-structured blockName naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Data /packages/data [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant