Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Use SCRIPT_DEBUG in end-to-end test environment #14845

Open
aduth opened this issue Apr 5, 2019 · 2 comments
Open

Testing: Use SCRIPT_DEBUG in end-to-end test environment #14845

aduth opened this issue Apr 5, 2019 · 2 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.

Comments

@aduth
Copy link
Member

aduth commented Apr 5, 2019

Previously: #14371 (comment)
Blocked by: #11360

The end-to-end test suite includes automatic test failures for console error logging. By using development-mode scripts, we can receive more messages (and more helpful messaging) from some vendor dependencies such as React which provide warning messages in development environments.

This is currently blocked by #11360, since there are currently known warnings which occur in development environments related to the use of unsafe lifecycle methods. These must first be resolved before SCRIPT_DEBUG can be activated by default.
@aduth aduth added [Type] Enhancement A suggestion for improvement. [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Status] Blocked Used to indicate that a current effort isn't able to move forward labels Apr 5, 2019
This was referenced Apr 5, 2019
Closed
Merged
Merged
@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Apr 10, 2019
@aduth
Copy link
Member Author

aduth commented May 23, 2019

As #11360 is now closed, it's technically not blocked any longer. I suspect there may still be some rogue errors which occur in some components (see also #14851, #15790).

@aduth aduth removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label May 23, 2019
This was referenced Jun 5, 2019
Merged
Closed
@WordPress WordPress deleted a comment Jun 10, 2019
@WordPress WordPress deleted a comment Jun 10, 2019
@WordPress WordPress deleted a comment Jun 10, 2019
@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Oct 21, 2019
@gziolo gziolo mentioned this issue Oct 24, 2019
Closed
@gziolo
Copy link
Member

gziolo commented Oct 24, 2019

It's blocked by #17355 which should be worked on first.

@gziolo gziolo added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Oct 24, 2019
@aduth aduth mentioned this issue Feb 28, 2020
Merged
@aduth aduth removed the Needs Dev Ready for, and needs developer efforts label Feb 28, 2020
@aduth aduth mentioned this issue Mar 2, 2020
Merged
6 tasks
@aduth aduth mentioned this issue Mar 31, 2020
Merged
9 tasks
@aduth aduth mentioned this issue May 13, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gziolo @aduth