-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect version in CHANGELOG.md for @wordpress/data
#15030
Comments
That's not specific to WordPress data, we don't update the CHANGELOG files if there's no "unreleased" entry in the files. I guess this should be closed once we land #13594 |
Can you clarify this a bit more please? Are saying that a package might get a version bump even if there's no changes in that package? Or are you saying there is a case here where someone has forgot to add changes to the I'm guessing by your reference to #13594 you mean the latter. If so, then should the CHANGELOG.md get updated to have the missing changes for 2.4.0? If you mean the former, then I wonder if we should add a disclaimer/note to the top of all changelogs that regardless of version of the package, there will only be entries where there are actual changes? |
I mean the latter but I don't want us to be monitoring changes and updating CHANGELOGs after the fact. I think having a note above changelogs is a solution but a better one is to add checks to avoid missing adding entries in the future.
But, this is also true as Lerna updates all the packages that depend on updated packages even with no changes in the said packages, which makes the note needed regardless. Edit I guess I mean both :) |
So can I make a suggestion for a note to add at the top of every changelog and then eventually we can do pulls to add it to our packages? Suggestion (we can iterate):
|
I think #15740 resolves the issue since we are now using |
Describe the bug
The
@wordpress/data
package.json has4.4.0
(the released version on npm), but the highest version in theCHANGELOG.md
file is4.3.0
. Not sure how this should be resolved yet, might need a review of when/where things were published and see where the versions went awry for the changelog.The text was updated successfully, but these errors were encountered: