Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter: Search should search all tabs, not just the active #1596

Closed
jasmussen opened this issue Jun 30, 2017 · 2 comments
Closed

Inserter: Search should search all tabs, not just the active #1596

jasmussen opened this issue Jun 30, 2017 · 2 comments
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@jasmussen
Copy link
Contributor

Right now search just searches the active tab. Ideally it should search through all tabs. Indeed the row of tabs should probably disappear as soon as you start searching, so when you tab from the search field after a successful search you enter the blocks.

Perhaps low priority considering the flux the inserter is in with #1588 and #888.

@westonruter
Copy link
Member

YES. I was going to comment on another issue that I think searching should return results from all the tabs, not just the one selected. I've repeatedly been frustrated recently when typing into the search box to quickly access a block, only to find that I hadn't selected the right tab first where the block is listed. So essentially I think there should be essentially a “search results” tab. This could have good tie-in with re-used external “shared blocks”, as noted in #1516. Searching can list matching block types first, followed by matches for all shared blocks that already exist.

@nylen nylen added the [Priority] High Used to indicate top priority items that need quick attention label Jul 5, 2017
@nylen
Copy link
Member

nylen commented Jul 5, 2017

Even knowing that this is the actual behavior, I get it wrong every time I try to use the inserter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants