Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Block: Toolbar positioning for wide and full images inconsistent #18217

Closed
mikeyarce opened this issue Oct 31, 2019 · 4 comments
Closed
Labels
[Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended

Comments

@mikeyarce
Copy link
Contributor

Describe the bug
When adding Wide and Full-Width images inside the Column Block, the toolbar positioning is not consistent.

To reproduce
Steps to reproduce the behaviour:

  1. Create a new Post
  2. Add a Column Block with at least 2 columns
  3. Add a Full Width image in one column
  4. Add a Wide image in another column
  5. The toolbar positioning seems off

Expected behaviour
The Toolbar should be aligned the same way.

Screenshots
Normal Image:
Screen Shot 2019-10-31 at 9 00 51 AM

Wide Image:
Screen Shot 2019-10-31 at 9 00 42 AM

Full Width Image:
Screen Shot 2019-10-31 at 9 00 47 AM

Desktop (please complete the following information):

  • OS: macOS Mojave
  • Browser Chrome
  • Version 78.0.3904.70 (Official Build) (64-bit)

I have a PR in place to fix the position of the block-mover which is currently underneath the toolbar: #18196

Once that PR is merged, what should be the position for the toolbar? I'm thinking they should all be like the "normal" image screenshot above.

@talldan talldan added the Needs Design Feedback Needs general design feedback. label Dec 16, 2019
@talldan
Copy link
Contributor

talldan commented Dec 16, 2019

Hi @mikeyarce. I always thought that the slightly inset position of the toolbar was on purpose 😄

I've added the Needs Design Feedback label, it'd be great to get an opinion from the design team on this.

@karmatosed
Copy link
Member

I am fairly sure it's not on purpose, let's mark as bug and get fixed :)

@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended and removed Needs Design Feedback Needs general design feedback. labels Dec 18, 2019
@mikeyarce
Copy link
Contributor Author

@karmatosed take a look at my proposed PR: #18196
Happy to make changes and with any feedback you might have! :)

@skorasaurus skorasaurus added the [Block] Columns Affects the Columns Block label Nov 27, 2020
@youknowriad
Copy link
Contributor

This is not valid anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants