Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate typography and text settings panels within the Paragraph block #23767

Closed
Tracked by #33447 ...
richtabor opened this issue Jul 7, 2020 · 2 comments · Fixed by #36334
Closed
Tracked by #33447 ...

Consolidate typography and text settings panels within the Paragraph block #23767

richtabor opened this issue Jul 7, 2020 · 2 comments · Fixed by #36334
Assignees
Labels
[Block] Paragraph Affects the Paragraph Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress

Comments

@richtabor
Copy link
Member

Describe the issue
Currently the Paragraph block features a "Typography" panel within the Settings sidebar for font size and line height, as well as a separate "Text settings" panel for the drop cap ToggleControl. I propose that we consolidate these panels into one, as they're all typographic controls.

Suggested behavior
Move the Drop cap control to the Typography panel within the Paragraph block's setting sidebar. This will simplify the sidebar by removing an unnecessary panel.

Screenshots
Screen Shot 2020-07-07 at 4 21 24 PM

@richtabor richtabor added Needs Design Feedback Needs general design feedback. [Block] Paragraph Affects the Paragraph Block labels Jul 7, 2020
@richtabor richtabor changed the title Consolidate typography and text settings within the Paragraph block Consolidate typography and text settings panels within the Paragraph block Jul 7, 2020
@gziolo gziolo added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Jul 9, 2020
@mapk
Copy link
Contributor

mapk commented Aug 25, 2020

This makes sense to me. I had a brief conversation with Rich in the Design Triage meeting today, and combining these could work if there is a way to hide certain settings from the component for blocks that don't require that particular setting.

I'd like to see us more forward with this, but am unsure on the technical details. cc @ItsJonQ

@mapk mapk added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Aug 25, 2020
@supernovia
Copy link

Here's a vote for keeping the Drop Cap controls separate, but giving them the same options so there's less disparity. Someone might want a drop cap with a teal background and white text, for example, without having to use CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paragraph Affects the Paragraph Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants