Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Navigation block's children on hover #25012

Closed
draganescu opened this issue Sep 2, 2020 · 8 comments · Fixed by #29869
Closed

Show Navigation block's children on hover #25012

draganescu opened this issue Sep 2, 2020 · 8 comments · Fixed by #29869
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Feature New feature to highlight in changelogs.

Comments

@draganescu
Copy link
Contributor

Description

Part of #24875
Update the behavior of Navigation block's interactivity:

  1. When the Navigation block is selected, hovering over a menu item with children should display those children in a dropdown.

  2. Selecting a menu item with children will force the display of those children. If a block other than the Navigation block is selected, hovering should have no affect on the display of children

@draganescu draganescu added [Block] Navigation Affects the Navigation Block [Type] Feature New feature to highlight in changelogs. labels Sep 2, 2020
@tellthemachines
Copy link
Contributor

We definitely had this at some point in the past and then it was removed. Would be good to know the reasons for removal before re-implementing.

@noisysocks
Copy link
Member

noisysocks commented Sep 29, 2020

We definitely had this at some point in the past and then it was removed. Would be good to know the reasons for removal before re-implementing.

I wonder if @getdave or @obenland remembers?

@obenland
Copy link
Member

I don't, unfortunately. Do we know when it was removed?

@getdave
Copy link
Contributor

getdave commented Sep 30, 2020

I don't remember I'm afraid. Actually, I believe it was our good friend @retrofox who was heavily involved in this aspect of show/hide on children.

Please note however, that when we were working on the Navigation block you could only add one type of child. With lots of blocks in play things have probably changed.

@retrofox
Copy link
Contributor

retrofox commented Oct 1, 2020

Hi, there. I remember we dealing with this issue, setting a proper box-model to don't lose the hovered stated among other pieces of the navigation, but not in detail, though :-(.
It's a fragile implementation in the sense if we aren't careful changing these values it could get broken.

it was our good friend @retrofox

<3

@grzim grzim self-assigned this Jan 17, 2021
@jasmussen
Copy link
Contributor

jasmussen commented Mar 15, 2021

Is this one done? #29713 landed recently which I believe addressed this one. @draganescu what do you think?

Edit: pasted the wrong ticket link.

@draganescu
Copy link
Contributor Author

The navigation block does not behave yet as described in this issue, particularly here:

If a block other than the Navigation block is selected, hovering should have no affect on the display of children

@jasmussen
Copy link
Contributor

Oh! I can fix that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants