Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reusable blocks to not depend on the editor module #25853

Closed
draganescu opened this issue Oct 6, 2020 · 1 comment
Closed

Refactor reusable blocks to not depend on the editor module #25853

draganescu opened this issue Oct 6, 2020 · 1 comment
Assignees
@adamziel
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Technical Feedback Needs testing from a developer perspective. [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

If we want the widgets editor to allow reusable blocks we need to refactor the reusable blocks functionality to not depend on @wordpress/editor as the widgets editor does not use this module.

@jorgefilipecosta added a few PRs to remove the dependency on @wordpress/editor from the Widgets editor and other places as sometimes the module is used as a convenience instead of for a real need.
@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Code Quality Issues or PRs that relate to code quality Needs Technical Feedback Needs testing from a developer perspective. [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Note Requires a developer note for a major WordPress release cycle labels Oct 6, 2020
@adamziel adamziel mentioned this issue Oct 6, 2020
Merged
6 tasks
@cguntur cguntur mentioned this issue Oct 14, 2020
Closed
17 tasks
@adamziel
Copy link
Contributor

Solved by #25859

@tellthemachines tellthemachines removed the Needs Dev Note Requires a developer note for a major WordPress release cycle label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamziel adamziel

Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Technical Feedback Needs testing from a developer perspective. [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@draganescu @adamziel @tellthemachines