Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice on Widgets Screen overlaps Page content #26221

Closed
DaisyOlsen opened this issue Oct 16, 2020 · 3 comments · Fixed by #32877
Closed

Notice on Widgets Screen overlaps Page content #26221

DaisyOlsen opened this issue Oct 16, 2020 · 3 comments · Fixed by #32877
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@DaisyOlsen
Copy link
Contributor

Describe the bug
When a nag or notice is present on the Widgets Screen the page content overlaps the notice.

To reproduce
Steps to reproduce the behavior:

  1. Trigger a nag or notice(In my case WooCommerce)
  2. Access Widgets Screen with Gutenberg plugin active
  3. See overlapping text

Expected behavior
Page content should push down below any on-screen notices

Screenshots
Screenshot on 2020-10-16 at 13-14-57

Editor version (please complete the following information):

  • WordPress version: 5.5.1
  • If the Gutenberg plugin is installed, which version is it? 9.1.1
@DaisyOlsen DaisyOlsen added [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended labels Oct 16, 2020
@noisysocks
Copy link
Member

@DaisyOlsen: How exactly do you trigger that notice? I installed WooCommerce but wasn't able to see it.

@DaisyOlsen
Copy link
Contributor Author

@noisysocks I just recreated the scenario and I guess I left a step out. - There has to be an admin notice loading on the screen. I was able to get one to display by installing and activating WooCommerce, skipping setup and then activating Facebook under marketing. I'm sure there are other plugins that would add a notice with fewer steps, but I don't have any examples at hand.

Basically, it seems that some pretty aggressive positioning is used in the styling, causing things to stack up. I didn't dig far enough to see if there was an easy solution.

@Mamaduka
Copy link
Member

Mamaduka commented Jun 10, 2021

It looks like Facebook for WooCommerce plugin used inline style to show notices. It overrides widget screen styles to hide notices.

I don't think we should fix this issue on our side since the widget editor screen does not cause it.

Notice added using default method are hidden and don't overlap with the header. Example:

add_action( 'admin_notices', function() {
	?>
	<div class="notice notice-success is-dismissible">
		<p><?php _e( 'Example notice...' ); ?></p>
	</div>
	<?php
} );

@tellthemachines tellthemachines self-assigned this Jun 22, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants