Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter search field just says "search for a block" but should suggest more #26222

Closed
mapk opened this issue Oct 16, 2020 · 4 comments
Closed
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Widgets Screen The block-based screen that replaced widgets.php. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance

Comments

@mapk
Copy link
Contributor

mapk commented Oct 16, 2020

Problem

The search field in the Inserter on the Widget screen suggests searching for a block, but people are also interested in widgets in this particular screen.

Existing example
Screen Shot 2020-10-16 at 1 15 15 PM

Solution

Change the text to read "Search for blocks and widgets"

@mapk mapk added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 16, 2020
@carolinan
Copy link
Contributor

In the inserter code, how can I use a condition for searchFormPlaceholder that only changes the text for the widget screen?
I don't know how to identify that the widget screen is being used.

@noisysocks
Copy link
Member

You might have to update Inserter so the tit accepts a placeholder prop which edit-widgets can then provide.

@draganescu draganescu added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement. labels Feb 18, 2021
@draganescu draganescu changed the title Widget Editor: Search field just says "search for a block" but should suggest more Inserter search field just says "search for a block" but should suggest more Feb 18, 2021
@noisysocks noisysocks added [Type] Copy Issues or PRs that need copy editing assistance and removed [Type] Enhancement A suggestion for improvement. labels Apr 19, 2021
@tellthemachines
Copy link
Contributor

The inserter now says only "Search" (both in the post and the widgets editor), because it now searches through blocks, patterns and reusable blocks all at once. Is this still worth changing here?

@noisysocks
Copy link
Member

Just "Search" is fine in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Widgets Screen The block-based screen that replaced widgets.php. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

No branches or pull requests

5 participants