Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the whole Widget Area when it is selected #26465

Closed
mapk opened this issue Oct 26, 2020 · 1 comment
Closed

Highlight the whole Widget Area when it is selected #26465

mapk opened this issue Oct 26, 2020 · 1 comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@mapk
Copy link
Contributor

mapk commented Oct 26, 2020

Problem

When clicking a collapsed widget area, the area's heading is highlighted with a blue border. This is good. However when the area is opened, the heading remains highlighted instead of the whole area. This doesn't look right.

Example of problem
highlight

Solution

Let's make the whole widget area highlighted in a blue border when it is selected, not just the area heading.

Screen Shot 2020-10-26 at 11 28 38 AM

@mapk mapk added [Type] Bug An existing feature does not function as intended Needs Dev Ready for, and needs developer efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 26, 2020
@draganescu draganescu added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Feb 18, 2021
@talldan
Copy link
Contributor

talldan commented Jul 7, 2021

I closed a similar issue related to this. I don't think this is the right thing to do, because it'd involve removing a focus style from the expand/collapse button, which is basically an accessibility regression.

None of the other accordions in WordPress do this, so I'm not sure why the widget area should be different.

@talldan talldan added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants