Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new Text Component (for Component System) #28020

Closed
1 of 13 tasks
ItsJonQ opened this issue Jan 6, 2021 · 1 comment
Closed
1 of 13 tasks

Integrate new Text Component (for Component System) #28020

ItsJonQ opened this issue Jan 6, 2021 · 1 comment
Assignees
Labels
[Feature] Component System WordPress component system [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues

Comments

@ItsJonQ
Copy link

ItsJonQ commented Jan 6, 2021

This is an extension of Implementing a Component System


Context ✨

The FontSizePicker component was first to receive the upgrade to use the new Components System.

We opted for a strategy (proposed by @gziolo) that imports and uses the various system parts via npm dependencies, rather than migrating the code by copying/pasting them over.

This was largely to expedite us figuring out the process for integration.
Using the new Component System code via external packages is not the end goal.


Text Component 🔠

Continuing this work, we'll need to (effectively) "backfill" the dependencies required for FontSizePicker. It's worth repeating that this was the original plan, but it was adjusted to expedite integration testing.

After chatting with @saramarcondes , we felt like a good candidate for this would be <Text />.

Reasons being that Text is a low-level and common UI element we plan on using in many places. Also, Text already exists as an experimental component in the project. The one coming from the new system is vastly improved.


Tasks ✅

In order to integrate the Text component we need to move the following dependencies into the GB repo in this order:


Tracking 📆

I've added the tasks (above) on a Google Spreadsheet Gaant chart as another way of tracking progress.

https://docs.google.com/spreadsheets/d/1gfzznyJtTr3hHoGkGRdeBRjhuZVMRalF9NuLrxkl4Nk/edit?usp=sharing


cc'ing @saramarcondes

@ItsJonQ ItsJonQ added [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues [Feature] Component System WordPress component system labels Jan 6, 2021
@ItsJonQ ItsJonQ self-assigned this Jan 6, 2021
@ItsJonQ
Copy link
Author

ItsJonQ commented Jan 28, 2021

I think we can close this one for #28475

@ItsJonQ ItsJonQ closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Component System WordPress component system [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Projects
None yet
Development

No branches or pull requests

1 participant