Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Cmd+A 2 times in widget areas selects all of the widget areas rather than the widgets #28267

Closed
kevin940726 opened this issue Jan 18, 2021 · 3 comments · Fixed by #31859
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kevin940726
Copy link
Member

Description

Pressing Cmd + a 2 times in widget areas selects all the widget areas, but not all the widgets inside the currently selected widget area. See the below screenshot for more info.

Step-by-step reproduction instructions

  1. Go to the widgets screen
  2. Select a widget area
  3. Focus on a random widget inside the widget area
  4. Press Cmd + a 2 times
  5. Notice all the widget areas get selected

Expected behaviour

It should instead selects all the widgets inside the currently focused widget area.

Actual behaviour

All the widget areas and all the widgets get selected

Screenshots or screen recording (optional)

Kapture.2021-01-18.at.15.20.54.mp4

Code snippet (optional)

WordPress information

  • WordPress version: 5.7-alpha-49956 (wp-env)
  • Gutenberg version: master branch
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: Desktop
  • Operating system: macOS
  • Browser: Chrome 87
@kevin940726 kevin940726 added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Jan 18, 2021
@draganescu draganescu self-assigned this Mar 29, 2021
@draganescu
Copy link
Contributor

Notes

The shortcut Primary + A twice will trigger multiSelect between the first and the last block in getBlockOrder() a selector in the block editor store which accepts an optional rootClientId "of the block list for which the order should be returned, defaulting to the top-level block order".

It feels like the getBlockOrder selector should either default to parent as rootClientId or we should rebind the select all shortcut in the widgets editor.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 1, 2021
@talldan
Copy link
Contributor

talldan commented May 17, 2021

Looks like this would also be fixed/improved by #31859, though it would still be possible to select widget areas.

@noisysocks noisysocks assigned talldan and unassigned draganescu May 17, 2021
@noisysocks
Copy link
Member

Assigning @talldan because IIRC he's taking over #30462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
4 participants