Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing Controls Don't Allow Decimals #31964

Closed
justintadlock opened this issue May 19, 2021 · 6 comments · Fixed by #32692
Closed

Spacing Controls Don't Allow Decimals #31964

justintadlock opened this issue May 19, 2021 · 6 comments · Fixed by #32692
Labels
Needs Testing Needs further testing to be confirmed. [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@justintadlock
Copy link
Contributor

When adding margin or padding, there is no way to add a decimal in the number. These are useful for at least rem, em, and % values.

To replicate, open the margin/padding spacing control and enter a number with decimal like 0.5 or 2.5. After clicking out of the number box, the control will automatically change these to 1 and 3, respectively.

Before:

unit-control-decimal

After:

unit-control-changed

@justintadlock
Copy link
Contributor Author

Also, negative values are not allowed either. I'm not sure if that is related enough for this ticket or should have a separate ticket of its own.

@aristath
Copy link
Member

If I'm not mistaken this is already in trunk and will be included in v10.7. Related PR: #30376

@carolinan
Copy link
Contributor

It is not solved in trunk 🤔

@aristath
Copy link
Member

PR #32692 fixes this 👍

@justintadlock
Copy link
Contributor Author

Is this fix in version 10.9.1? I am still unable to add something like 2.5 with rem for the padding control. It bumps it up to 3.

@aristath
Copy link
Member

aristath commented Jul 2, 2021

Is this fix in version 10.9.1? I am still unable to add something like 2.5 with rem for the padding control. It bumps it up to 3.

I just checked and it was not included in v10.9.x. It will be part of v11 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed. [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants