Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget Editor: Legacy Widget container does not contain floated content #32969

Closed
dreamwhisper opened this issue Jun 24, 2021 · 0 comments · Fixed by #32976
Closed

Widget Editor: Legacy Widget container does not contain floated content #32969

dreamwhisper opened this issue Jun 24, 2021 · 0 comments · Fixed by #32976
Assignees
@tellthemachines
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@dreamwhisper
Copy link

dreamwhisper commented Jun 24, 2021 •
edited
Loading

Description

In both the customizer and the widgets screen, the wp-block-legacy-widget__edit-form div does not contain forms with floated elements.

Step-by-step reproduction instructions

Please list the steps needed to reproduce the bug. For example:

  1. Get Genesis & Genesis Sample
  2. Go to Appearance > Widgets or Customizer > Widgets
  3. Add a Genesis - Featured Post widget to the Footer 1 widget area.
  4. Note that the wp-block-legacy-widget__edit-form div does not contain forms with floated form elements.

Expected behaviour

The wp-block-legacy-widget__edit-form div will fully contain forms with floated form elements.

Previously, we used the widget-control-actions div to prevent this. (We can update our CSS, of course, but there are some additional issues.)

Actual behaviour

The wp-block-legacy-widget__edit-form div does not contain forms with floated form elements.

Screenshots or screen recording (optional)

Screen Shot 2021-06-24 at 3 25 28 PM

Screen Shot 2021-06-24 at 3 23 53 PM

Code snippet (optional)

WordPress information

  • WordPress version: 5.8-beta3-51224
  • Gutenberg version: Not installed"
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? No - Get Genesis

Device information

  • Device: Mac
  • Operating system: MacOS 10.15.x
  • Browser: Chrome 91
@dreamwhisper dreamwhisper changed the title Legacy Widget container does not contain content Widget Editor: Legacy Widget container does not contain content Jun 24, 2021
@dreamwhisper dreamwhisper mentioned this issue Jun 24, 2021
Closed
@johnstonphilip johnstonphilip added [Feature] Full Site Editing [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended and removed [Feature] Full Site Editing labels Jun 25, 2021
@talldan talldan added CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jun 25, 2021
@talldan talldan changed the title Widget Editor: Legacy Widget container does not contain content Widget Editor: Legacy Widget container does not contain floated content Jun 25, 2021
@tellthemachines tellthemachines self-assigned this Jun 25, 2021
@tellthemachines tellthemachines mentioned this issue Jun 25, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tellthemachines tellthemachines

Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wide widget styles to allow floated contents. WordPress/gutenberg
4 participants
@talldan @dreamwhisper @johnstonphilip @tellthemachines