Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: replace legacy ColorPicker with new version #34287

Closed
7 tasks
Tracked by #34284
ciampo opened this issue Aug 25, 2021 · 0 comments · Fixed by #35220
Closed
7 tasks
Tracked by #34284

Components: replace legacy ColorPicker with new version #34287

ciampo opened this issue Aug 25, 2021 · 0 comments · Fixed by #35220
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Feature New feature to highlight in changelogs.

Comments

@ciampo
Copy link
Contributor

ciampo commented Aug 25, 2021 •
edited by mtias
Loading

Part of #34284

Why

The new ColorPicker should replace the legacy version of the component

What

This effectively means moving the code of the g2 component over to the src folder of the @wordpress/components package, completely replacing the legacy component.

We need to ensure that usages of the ColorPicker keep working as expected, despite the changes.

A/C

  • The new ColorPicker is promoted to the src folder, replacing the legacy component (a legacy adapter has already been created in components: Add deprecated props adapter for ColorPicker #34014)
    • The code of the legacy ColorPicker is deleted
  • Asses any potential breaking change introduced
  • Test that the component works as expected, in continuity with the previous version:
    • In storybook
    • In the usages across the Gutenberg repository
  • Introduce a changelog entry
@ciampo ciampo mentioned this issue Aug 25, 2021
Closed
31 tasks
@ciampo ciampo added [Feature] Component System WordPress component system [Package] Components /packages/components [Type] Feature New feature to highlight in changelogs. labels Aug 25, 2021
@ciampo ciampo changed the title Replace the "legacy" ColorPicker with the g2 version Components: Replace the "legacy" ColorPicker with the g2 version Aug 25, 2021
@ciampo ciampo changed the title Components: Replace the "legacy" ColorPicker with the g2 version Components: replace the "legacy" ColorPicker with the g2 version Aug 25, 2021
@ciampo ciampo changed the title Components: replace the "legacy" ColorPicker with the g2 version Components: replace legacy ColorPicker with the g2 version Aug 25, 2021
@mtias mtias changed the title Components: replace legacy ColorPicker with the g2 version Components: replace legacy ColorPicker with new version Aug 25, 2021
@jasmussen jasmussen mentioned this issue Sep 7, 2021
Merged
@ciampo ciampo mentioned this issue Oct 4, 2021
Merged
@npneeraj npneeraj mentioned this issue Nov 26, 2023
Open
This was referenced Nov 27, 2023
Open
Open
This was referenced Nov 27, 2023
Open
Open
@captainbarber99 captainbarber99 mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace the color picker component with the new version WordPress/gutenberg
1 participant
@ciampo