Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save as..." for Reusable Blocks #35113

Closed
jameskoster opened this issue Sep 24, 2021 · 4 comments
Closed

"Save as..." for Reusable Blocks #35113

jameskoster opened this issue Sep 24, 2021 · 4 comments
Labels
[Block] Block The "Reusable Block" Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Needs design efforts.

Comments

@jameskoster
Copy link
Contributor

It's not always clear where your edits will take you when working with a Reusable Block. Occasionally you'll find yourself making changes that are so extensive that creating a brand new Reusable Block becomes desirable.

Unless I'm mistaken, if you wanted to do this currently you'd need to copy/paste the blocks, create a new Reusable Block, then undo all the changes you made to the one you were originally working with... this is a bit of an ordeal.

When #32464 is merged it will be possible to save reusable blocks directly from their toolbar.

Screenshot 2021-09-24 at 12 08 30

I wonder if we could use this pattern to introduce a "Save as..." option? Or maybe something simpler, exposed in the ellipsis menu?

Screenshot 2021-09-24 at 13 54 15

Naturally we'd need to expose this functionality in the multi-entity save panel too. Perhaps this makes the ellipsis menu a better location.

@jameskoster jameskoster added Needs Design Needs design efforts. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Block] Block The "Reusable Block" Block labels Sep 24, 2021
@karmatosed
Copy link
Member

If adding save as, I think the ellipsis works a little better than the 'save as' dropdown - however that might be because the flow is new. Maybe with some iterations that could work but I'm not convinced.

@jameskoster
Copy link
Contributor Author

Yeah the ellipsis probably makes more sense when we think about how we might present this affordance in the multi-entity save interface:

Screenshot 2021-09-27 at 11 15 53

Especially when we consider other potential actions like discarding changes, or renaming.

@jordesign
Copy link
Contributor

#32464 is not yet merged - so there's currently no way to specifically Save Synced Patterns in the toolbar. But this may be something we want to keep open to keep considering. What do you think @jameskoster ?

@jameskoster
Copy link
Contributor Author

The pattern management experience evolved a lot in 6.3 where it is now possible to duplicate and edit individual patterns in isolation. We can probably close this out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Block The "Reusable Block" Block [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

3 participants