Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo (keyboard shortcode) not working in meta box area #38731

Open
rilwis opened this issue Feb 11, 2022 · 9 comments
Open

Undo (keyboard shortcode) not working in meta box area #38731

rilwis opened this issue Feb 11, 2022 · 9 comments
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Bug An existing feature does not function as intended

Comments

@rilwis
Copy link

rilwis commented Feb 11, 2022

Description

This issue might be related to #18755. But the scope of #18755 is wide and covers other things. So I open this issue to be more specific.

When adding any text/textarea custom field to posts using a plugin like Meta Box, ACF (or any method that register meta box with add_meta_box function); or use a plugin that register a normal meta box like Slim SEO, we can't undo the changes inside input boxes provided by these plugins. Pressing Cmd/Ctrl + Z does nothing.

Step-by-step reproduction instructions

  1. Install the Slim SEO plugin, it register a meta box under the post content
  2. Edit a post
  3. Enter some text in the meta title or meta desription
  4. Press Cmd/Ctrl + Z and see it does nothing

Screenshots, screen recording, code snippet

No response

Environment info

WordPress 5.9. Use default standard, not the Gutenberg plugin individually.

Tried with Slim SEO 3.13.1 and Meta Box 5.5.1.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added [Feature] Meta Boxes A draggable box shown on the post editing screen [Feature] History History, undo, redo, revisions, autosave. Needs Testing Needs further testing to be confirmed. labels Feb 14, 2022
@maksymmamontov
Copy link

Can confirm that Undo is inconsistent not only Advanced Custom Fields but in all the input/textarea fields in native Gutenberg Editor.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Sep 10, 2022
@hj-collab
Copy link

@Thelmachido Did you even read the issue? OP is talking about undo inside the meta box area and not in the post content area. Try undoing inside Meta title, Meta description fields.

@Thelmachido
Copy link

@hj-collab thanks for the ping, I followed the reproduction steps and I missed a few things there. My apologies for the mixup, I will check the steps again.

@Thelmachido Thelmachido reopened this Sep 15, 2022
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Sep 16, 2022
@ndiego ndiego added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Oct 11, 2022
@ndiego
Copy link
Member

ndiego commented Oct 11, 2022

This issue was reviewed in today's Editor Bug Scrub and has been confirmed.

@maksymmamontov
Copy link

@ndiego anyway I can help with fixing this issue?

@maksymmamontov
Copy link

@ndiego could you please just add two exceptions for Undo key, so it won't trigger default Gutenberg Undo functionality for textarea and input.
this minor fix will solve 99% of this issue.

@landwire
Copy link

@ndiego
This is a very old threat, but the issue is still not resolved. Was there any outcome of the bug scrub and will this problem be fixed at some point?

@ndiego
Copy link
Member

ndiego commented Jul 21, 2024

will this problem be fixed at some point?

I cannot say for sure, and anyone is welcome to submit a PR, but metaboxes cause a number of other issues in the Editor, and there is a concerted effort to encourage developers to use alternative options. I know I have for all my projects. Here are a few relevant links:

@ryanwelcher and I actually ran a Developer Hours session on this topic back in May. You can find the recording on WordPress.tv.

@landwire
Copy link

landwire commented Jul 21, 2024

@ndiego
Thank you for the update, clarification and relevant links.
I have not checked out the recording yet, so maybe alternative options are viable.
I am using ACF Pro at the moment to create the fields for custom blocks, as it is a very fast workflow without having to have additional build steps or React knowledge.
Is there any info in the recording on how to replace that ACF Pro workflow without deep React knowledge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

7 participants