Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom size icon on Typography tools doesn't display tooltip #38931

Closed
maddisondesigns opened this issue Feb 20, 2022 · 2 comments · Fixed by #38985
Closed

Set custom size icon on Typography tools doesn't display tooltip #38931

maddisondesigns opened this issue Feb 20, 2022 · 2 comments · Fixed by #38985
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@maddisondesigns
Copy link

Description

There's no tooltip displayed when you hover over the Set custom size icon so there's no indication what the icon actually does.

Gutenberg.Typography.set.custom.size.tooltip.mp4

Step-by-step reproduction instructions

  • Click on a paragraph block
  • Hover cursor over Set custom size icon
  • No tooltip displays

Screenshots, screen recording, code snippet

No response

Environment info

WP 5.9
Twenty Twenty One
Firefox 97.0.1
macOS 12.1
No Gutenberg plugin, core only

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Components /packages/components [Type] Enhancement A suggestion for improvement. labels Feb 22, 2022
@Mamaduka
Copy link
Member

@ntsekouras, do you remember the reason why tooltips are currently hidden?

@ntsekouras
Copy link
Contributor

@ntsekouras, do you remember the reason why tooltips are currently hidden?

I can't think of any reason and especially since I was handling the message conditionally. Must have missed it 😄 . Opened a quick fix here: #38985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants