Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons block - Opening the settings hides some of the formatting buttons #39491

Closed
geriux opened this issue Mar 16, 2022 · 1 comment · Fixed by #40725
Closed

Buttons block - Opening the settings hides some of the formatting buttons #39491

geriux opened this issue Mar 16, 2022 · 1 comment · Fixed by #40725
Assignees
@fluiddot
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@geriux
Copy link
Member

geriux commented Mar 16, 2022

Description

While testing another feature a bug was found in the Buttons block on Android where opening the block's settings would hide some of the formatting options once the Bottom sheet is closed.

Most likely the issue is around this code.

Step-by-step reproduction instructions

  • Open the app
  • Add a Buttons block
  • Open the block's settings
  • Dismiss the Bottom sheet

Expected behaviour

All of the formatting options should be visible after dismissing the Bottom sheet.

Actual behaviour

Only the link option is visible.

Screenshots or screen recording (optional)

ButtonBug.mov

Device information

  • Device: Pixel 5 (Emulator)
  • Operating system: Android 12
  • WordPress app version: Latest
@geriux geriux added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Mar 16, 2022
@hypest hypest added the [Priority] High Used to indicate top priority items that need quick attention label Mar 18, 2022
@hypest
Copy link
Contributor

hypest commented Mar 18, 2022

Marked as [Priority] High as it's a regression to basic functionality for a block.

@fluiddot fluiddot self-assigned this Apr 27, 2022
@fluiddot fluiddot mentioned this issue Apr 29, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 29, 2022
@jhnstn jhnstn mentioned this issue May 11, 2022
Merged
4 tasks
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fluiddot fluiddot

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
4 participants
@hypest @geriux @fluiddot @priethor