Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: rework focus/blur callback behavior across composite components #39615

Open
1 of 7 tasks
ciampo opened this issue Mar 21, 2022 · 2 comments
Open
1 of 7 tasks
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@ciampo
Copy link
Contributor

ciampo commented Mar 21, 2022

What problem does this address?

We should align composite components with focusable sub-components (e.g. UnitControl, RangeControl, ...) so that they share the same behavior when it comes to how the onFocus/onBlur callbacks are fired

See #39589 (review) for more details

What is your proposed solution?

  • List components that need to be addressed
  • For each component, make sure that the onFocus and onBlur callbacks fire if any sub-component is focused or blurred

List of components

@ciampo ciampo added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components [Feature] Component System WordPress component system labels Mar 21, 2022
@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Sep 27, 2022
@ciampo
Copy link
Contributor Author

ciampo commented Sep 27, 2022

This issue is still relevant, but we'll need to assess the status of the components mentioned above as we're in the process of introducing SlideControl (and later deprecate RangeControl) as per #40507

@ciampo ciampo removed the Needs Testing Needs further testing to be confirmed. label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant