Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display HTML anchor link for Group block in List View #40456

Closed
inaikem opened this issue Apr 20, 2022 · 4 comments · Fixed by #40458
Closed

Display HTML anchor link for Group block in List View #40456

inaikem opened this issue Apr 20, 2022 · 4 comments · Fixed by #40458
Assignees
@Mamaduka
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended

Comments

@inaikem
Copy link

inaikem commented Apr 20, 2022

What problem does this address?

Improving consistency and user experience in the List View.

Currently HTML anchor text is shown as a grey label in the List View for only some blocks (eg Heading, Spacer), but not others. See below:
 

Annotation on 2022-04-20 at 10-37-08

What is your proposed solution?

I'd like to request we display any HTML Anchor text set by users in the List View for all blocks.
@inaikem inaikem mentioned this issue Apr 20, 2022
Closed
@annezazu
Copy link
Contributor

This might be able to be closed out since it overlaps so much with the following two issues: #16296 #33583 What do you think? Adding labels to be safe either way :)

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Apr 20, 2022
@inaikem
Copy link
Author

inaikem commented Apr 20, 2022

#33583 especially looks super interesting! This request might well be superseded but it's a nice to have in the interim if its an easy enough addition to make 🤞

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Apr 20, 2022
@Mamaduka
Copy link
Member

I think this is a bug. I can confirm that Group doesn't display anchor, while other blocks do. The original feature was added via #31992.

@Mamaduka Mamaduka mentioned this issue Apr 20, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 20, 2022
@annezazu
Copy link
Contributor

annezazu commented Apr 20, 2022 •
edited
Loading

Great sleuthing per usual @Mamaduka! Thanks for a PR as well <3 Updating the title to reflect the bug too.

@annezazu annezazu changed the title Display HTML anchor link (or ID) for Group and other blocks in List View Display HTML anchor link for Group block in List View Apr 20, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

useBlockDisplayInformation: Return anchor for block variations WordPress/gutenberg
4 participants
@Mamaduka @annezazu @priethor @inaikem