Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Variations: Add warning when custom styles will be lost #40561

Closed
clubkert opened this issue Apr 22, 2022 · 1 comment
Closed

Style Variations: Add warning when custom styles will be lost #40561

clubkert opened this issue Apr 22, 2022 · 1 comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@clubkert
Copy link
Contributor

What problem does this address?

If a user creates a custom style and then switches to another style variation, the previous customizations are lost.

In the below video, I switch the background color to a gradient. However, if I then try out different style variations, my previous settings are lost with no warning.

Screen.Recording.2022-04-22.at.3.51.20.PM.mov

What is your proposed solution?

If I've made changes to my style settings, I'd expect a warning before switching to another variation letting me know that I'll lose my changes if I don't save the page first.

This might be related to saving style variations (#38333)
@clubkert clubkert mentioned this issue Apr 22, 2022
Closed
@carolinan carolinan added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 25, 2022
@jameskoster jameskoster mentioned this issue Apr 18, 2023
Closed
@priethor priethor added the Needs Design Needs design efforts. label Apr 28, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 14, 2023
@jordesign jordesign changed the title Add warning when custom styles will be lost Style Variations: Add warning when custom styles will be lost Sep 14, 2023
@jordesign jordesign added [Feature] Theme Style Variations Related to style variations provided by block themes and removed [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Sep 14, 2023
@glendaviesnz glendaviesnz mentioned this issue Dec 1, 2023
Closed
@annezazu annezazu mentioned this issue Dec 5, 2023
Open
@annezazu
Copy link
Contributor

annezazu commented Dec 5, 2023

Closing this out in favor of this overall issue that references this problem as something to solve: #45371 Thank you for opening this!

@annezazu annezazu closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jordesign @clubkert @carolinan @annezazu @priethor