Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the add_theme_support feature name for wide images #4113

Closed
pyronaur opened this issue Dec 20, 2017 · 4 comments
Closed

Change the add_theme_support feature name for wide images #4113

pyronaur opened this issue Dec 20, 2017 · 4 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@pyronaur
Copy link
Contributor

Currently to add wide-image support theme developers have to do this:

    add_theme_support(
        'gutenberg',
        array(
            'wide-images' => true,
        )
    );

That should probably be renamed to something like:

add_theme_support('align-wide')
// or
add_theme_support('wide-alignments')

cc @youknowriad, @jasmussen

@youknowriad
Copy link
Contributor

Two reasons behind this:

  • Avoid the "gutenberg" code name in production
  • The "wide-images" option is not only for images but all blocks supporting wide alignments.

@pyronaur
Copy link
Contributor Author

Thanks for the clarification 👍

@Luehrsen
Copy link
Contributor

Just to add to the conversation:

There are a lot of cases, where the availability of wide-alignments cannot be set globally. Sometimes we provide extra Page Templates for that functionality, sometimes it's special post types.

So having the ability to narrow availability down would be great.

@maddisondesigns
Copy link

I also mentioned something similar in #2823 a few months ago, that it would be a good idea to rename these, as it's confusing that 'adding support' for 'wide-images' also does the same thing for tables as well.

@youknowriad youknowriad added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

4 participants