Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Post/Block tab switcher with TabPanel #43414

Closed
mirka opened this issue Aug 19, 2022 · 4 comments
Closed

Replace Post/Block tab switcher with TabPanel #43414

mirka opened this issue Aug 19, 2022 · 4 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Post /packages/edit-post

Comments

@mirka
Copy link
Member

mirka commented Aug 19, 2022

Prerequisite for #41904 #42320

The Post/Block tab switcher in the Inspector (.edit-post-sidebar__panel-tabs) is currently implemented as a list of buttons, and is missing tabpanel semantics.

The Post/Block tab switcher

This should be replaced with the TabPanel component.

@mirka mirka added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Post /packages/edit-post labels Aug 19, 2022
@talldan
Copy link
Contributor

talldan commented Feb 1, 2023

I found this old PR that attempted to do this, but was closed - Use TabPanel in edit settings sidebar header (#13587).

It looks like one issue surfaced in that PR (and has come up a few times recently in other issues) is that TabPanel may have to become a controlled component. I think when you deselect a block the selected tab changes from 'Block' to 'Post'.

@mirka
Copy link
Member Author

mirka commented Feb 1, 2023

It looks like one issue surfaced in that PR (and has come up a few times recently in other issues) is that TabPanel may have to become a controlled component.

Ah, #46704 may unblock it then.

@alexstine
Copy link
Contributor

@aaronrobertshaw asked for my feedback over here in another issue.

I highly support this now that the TabPanel is working better than it ever has before. Cannot wait to see this happen. This will move us another step in the right direction of having consistent controls/interactions.

Thanks.

@mirka
Copy link
Member Author

mirka commented Dec 22, 2023

Closed by #55360

@mirka mirka closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Post /packages/edit-post
Projects
Status: Done 🎉
Development

No branches or pull requests

3 participants