Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add more inner blocks to a quote block once a list inner block is added, using normal keyboard strokes #44625

Closed
jpollock opened this issue Sep 30, 2022 · 2 comments · Fixed by #44809
Assignees
Labels
[Block] List Affects the List Block [Block] Quote Affects the Quote Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Accessibility Feedback Need input from accessibility [Type] Bug An existing feature does not function as intended

Comments

@jpollock
Copy link

Description

Once I add a List block to a Quote block, I am unable to add other blocks, to the Quote block, using keyboard strokes, e.g. enter or arrow up or down. My expectation is that I would be able to use similar keystrokes, to get to add new inner blocks. The attached gif shows the issue best.

Step-by-step reproduction instructions

  1. Create a new post;
  2. Add a Quote block;
  3. Within the Quote block, add a List block;
  4. Type some text, to add an item to the list;
  5. There is no immediately obvious way to add another, as a peer to the list, within the quote block;
  6. If one properly selects the list block, in its entirety, then one can place mouse in the "Add citation" section and then use the "Add Block" button.

Expectation is that there would be a more apparent way to do that, either through navigation or buttons.

Screenshots, screen recording, code snippet

issue_with_list_block_in_quote_block

Environment info

WordPress version: WordPress 6.1-beta2 (running in Local)
Gutenberg version: N/A
Are all plugins except Gutenberg deactivated? No; using WordPress Beta Tester plugin
Are you using a default theme (e.g. Twenty Twenty-One)? Twenty Twenty-Three
OS: macOS Monterey 12.6
Browser: tested in Chrome, Firefox and Safari

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added [Block] Quote Affects the Quote Block [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Sep 30, 2022
@sarahricker sarahricker added the Needs Accessibility Feedback Need input from accessibility label Sep 30, 2022
@benridane
Copy link
Contributor

benridane commented Oct 1, 2022

It was able to reproduce it.
Gutenberg version: 14.2.0

It was NOT able to reproduce it.
Gutenberg version: 13.X

It was also reproduced in Group blocks.

@torounit torounit added the [Block] List Affects the List Block label Oct 1, 2022
@benridane
Copy link
Contributor

It found out that canOutdent process checked only grandParent is exists or not.
In this case, parentBlock inside of GroupBlock is always true.

List Item should only move when Grand Parent is List Item.

const { getBlockRootClientId } = innerSelect( blockEditorStore );
const grandParentId = getBlockRootClientId(
getBlockRootClientId( clientId )
);
return {
canOutdent: !! grandParentId,

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 10, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Block] Quote Affects the Quote Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Accessibility Feedback Need input from accessibility [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants