Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Remove OffCanvasEditor component #46934

Closed
scruffian opened this issue Jan 6, 2023 · 3 comments
Closed

Navigation: Remove OffCanvasEditor component #46934

scruffian opened this issue Jan 6, 2023 · 3 comments
Labels
[Block] Navigation Affects the Navigation Block [Status] Blocked Used to indicate that a current effort isn't able to move forward

Comments

@scruffian
Copy link
Contributor

scruffian commented Jan 6, 2023 •
edited
Loading

What problem does this address?

The OffCanvasEditor component is a duplicate of the list view component with small modifications. You can see these differences here: #46935

What is your proposed solution?

We should aim to update the list view component to allow the changes from the OffCanvasEditor component and then remove it
@scruffian scruffian added the [Block] Navigation Affects the Navigation Block label Jan 6, 2023
@scruffian scruffian mentioned this issue Mar 8, 2023
Closed
@scruffian
Copy link
Contributor Author

We can't do this until we've done:
#46991
#46993
#46992

@scruffian scruffian added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Mar 8, 2023
This was referenced Mar 8, 2023
Closed
Closed
@scruffian
Copy link
Contributor Author

This is will require us to solve the following issues:
#49918
#50287

@scruffian
Copy link
Contributor Author

Fixed by #50705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block [Status] Blocked Used to indicate that a current effort isn't able to move forward
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scruffian