Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Make the OffCanvasEditor the default experience. #46938

Closed
scruffian opened this issue Jan 6, 2023 · 4 comments · Fixed by #46995
Closed

Navigation: Make the OffCanvasEditor the default experience. #46938

scruffian opened this issue Jan 6, 2023 · 4 comments · Fixed by #46995
Assignees
Labels
[Block] Navigation Affects the Navigation Block Needs Accessibility Feedback Need input from accessibility

Comments

@scruffian
Copy link
Contributor

scruffian commented Jan 6, 2023

What problem does this address?

Based on the feedback on https://make.wordpress.org/test/2022/12/14/fse-program-testing-call-19-running-through-refinements/, let's make the OffCanvasEditor the default experience for the navigation block.

This means removing all references to window?.__experimentalEnableOffCanvasNavigationEditor in the code.

One thing to note is that the global navigation sidebar in the Site Editor is also using this experiment to hide its functionality. This sidebar is not yet ready to be moved out of an experiment, so we should ensure that it remains hidden behind this (or another) flag.

Another thing to be aware of is that this experiment is reliant on the tabs in the inspector controls. Both of these experiments need to be made the default. @aaronrobertshaw do you have a plan for this?

A reminder here are the calls for testing:

@scruffian scruffian added the [Block] Navigation Affects the Navigation Block label Jan 6, 2023
@ajlende ajlende self-assigned this Jan 9, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 9, 2023
@talldan
Copy link
Contributor

talldan commented Jan 10, 2023

It's good to see that an accessibility review has been requested ❤️

Some styling issues I've spotted that might be good to resolve and bring more in line with List View ...

In List View the main focus ring surrounds the entire row, which isn't always the case in the off canvas editor

List View Off Canvas Editor
Screen Shot 2023-01-10 at 1 02 18 pm Screen Shot 2023-01-10 at 1 02 59 pm

Lock and Block Settings icons are not aligned between rows

List View Off Canvas Editor
Screen Shot 2023-01-10 at 1 05 56 pm Screen Shot 2023-01-10 at 1 06 46 pm

Horizontal scroll bars often display

Screen Shot 2023-01-10 at 1 07 46 pm

@getdave getdave added the Needs Accessibility Feedback Need input from accessibility label Jan 10, 2023
@getdave
Copy link
Contributor

getdave commented Jan 10, 2023

For additional context I've updated the Issue description with links to the x2 calls for testing that were made on Make Blog for this feature over the past few months.

@aaronrobertshaw
Copy link
Contributor

Another thing to be aware of is that this experiment is reliant on the tabs in the inspector controls. Both of these experiments need to be made the default. @aaronrobertshaw do you have a plan for this?

I'll be putting together a PR to stabilize the inspector controls tabs today in the hope we might be able to get it reviewed and merged in time for the next Gutenberg release. That would give us two full Gutenberg releases with it as the default experience before the WordPress 6.2 feature freeze.

@aaronrobertshaw
Copy link
Contributor

#47045 was just merged stabilizing the block inspector tabs experiment.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Accessibility Feedback Need input from accessibility
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants