Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Publish navigate region focus style hides the whole sidebar #48031

Closed
afercia opened this issue Feb 13, 2023 · 1 comment · Fixed by #48102
Closed

The Publish navigate region focus style hides the whole sidebar #48031

afercia opened this issue Feb 13, 2023 · 1 comment · Fixed by #48102
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Interface /packages/interface [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Feb 13, 2023

Description

This appears to be a regression after #47734.

The CSS changes from #47734 fixed the publish sidebar when saving multi-entities but broke the focus style of the Publish region when normally navigating through the editor regions.

When the Publish region is focused, the whole sidebar is now hidden under a white container. Also, the focus style extends to the whole sidebar, while it should show only around the 'Open publish panel' container.

Step-by-step reproduction instructions

  • Open the post editor.
  • Use the Control + backtick keyboard shortcut (or the alternative shortcuts) to navigate through the editor regions.
  • Navigate to the Publish region i.e.: the one that contains the button 'Open publish panel' .
  • Observe a white container shows up and hides the whole sidebar.
  • Observe the focus style extends to the whole white container.
  • See screenshots for clarity.

To confirm the regression:

Note: It's perfectly understandable that such visual regressions occur. However, this is not the first time the navigate region focus style breaks. It broke several times, actually. One more reason to take into strong consideration the introduction of visual regression testing, see for example a related Draft PR here: #46210

Screenshots, screen recording, code snippet

Expected:

expected

Actual:

actual

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release [Package] Edit Post /packages/edit-post labels Feb 13, 2023
@afercia afercia changed the title Post Editor: Navigate publish region focus style hides the whole sidebar The Publish navigate region focus style hides the whole sidebar Feb 15, 2023
@afercia
Copy link
Contributor Author

afercia commented Feb 15, 2023

Additionally, in the Site Editor, the 'Save' region shows the 'Open save panel' container full height and the button is at thte top:

Screenshot 2023-02-15 at 09 06 18

It is expected to show at the bottom right of the screen:

Screenshot 2023-02-15 at 10 13 40

Probably regressed in #47142

@afercia afercia self-assigned this Feb 15, 2023
@afercia afercia added [Package] Interface /packages/interface [Package] Edit Site /packages/edit-site labels Feb 15, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 15, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Interface /packages/interface [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants