Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the navigate regions sidebars show full height #48186

Open
afercia opened this issue Feb 17, 2023 · 0 comments
Open

Make the navigate regions sidebars show full height #48186

afercia opened this issue Feb 17, 2023 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Feb 17, 2023

Description

When navigating through the editor regions with the Control + backtick keyboard shortcut and any right sidebar is closed, the sidebar region shows only a button to open the related sidebar. For example, in the post editor:

Screenshot 2023-02-17 at 11 26 43

In #48102 @youknowriad made a good point that these sidebars could always be shown full height. For example:

Screenshot 2023-02-17 at 11 28 24

Making them full height would bring in some pros:

  • The 'Open' buttons would be more prominent. Showing something at the top right is better than at the bottom right because of the 'F pattern'. Improved accessibility.
  • It would allow some code simplification.

If that's OK from a dsign perspective, I'd be in favor of this change.

The change should be made both in the Post editor and in the Site editor for the sidebars that show the buttons:

  • Open document settings
  • Open publish panel
  • Open save panel

To make this change:

Step-by-step reproduction instructions

  • Go to the Post editor.
  • Close all sidebars.
  • Navigate through the regions by using the Control + backtick keyboard shortcut (or Control+Option+N).
  • Observe the regions with the 'Open' buttons show at the bottom right of the screen.
  • Go to the Site editor.
  • Close all sidebars.
  • Navigate through the regions.
  • Observe the region with the 'Open' button shows at the bottom right of the screen.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site labels Feb 17, 2023
@youknowriad youknowriad changed the title Make the navigate regions sidebars show full width Make the navigate regions sidebars show full height Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant