Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Loop Block: Continued iteration on bundled patterns #49280

Open
annezazu opened this issue Mar 22, 2023 · 6 comments
Open

Query Loop Block: Continued iteration on bundled patterns #49280

annezazu opened this issue Mar 22, 2023 · 6 comments
Assignees
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

We need a query pattern of a grid of featured images as a starting point. We need much more optionality on query patterns in general.

Pulled from #48443 and a follow up to #44140

cc @richtabor in case you have time to work on this.

@annezazu annezazu added Needs Design Needs design efforts. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Block] Query Loop Affects the Query Loop Block labels Mar 22, 2023
@richtabor richtabor self-assigned this Mar 22, 2023
@richtabor
Copy link
Member

I'll see what I can do, though last I experimented the blockGap limitation (#44899) was making it difficult to get spacing right in a grid layout.

@tellthemachines
Copy link
Contributor

I'm thinking #49050 might be helpful to move this forward, but it needs a bit of input on how we want the columns behaviour in the grid template to work. The V1 of grid layout only allows setting a minimum column width, not a number of columns, but has the advantage of better responsivity out of the box vs the current solution. Using the grid layout will also allow us to easily add block spacing, which would fix #44899.

@richtabor
Copy link
Member

Using the grid layout will also allow us to easily add block spacing, which would fix #44899.

Post Template should probably have block gap too, as its children will inherit that parent block's spacing value — not the query loop's.

Using the grid layout will also allow us to easily add block spacing, which would fix #44899.

As long as using grid layout isn't required for block spacing support.

@mtias
Copy link
Member

mtias commented Jun 29, 2023

What's the status here? Is there anything actionable remaining?

@annezazu
Copy link
Contributor Author

Yes, we need to incorporate more patterns still! Room for improvement remains.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 26, 2023
@annezazu
Copy link
Contributor Author

Noting that another pattern that's needed is one that shows everything: post titles, full post content, tags, categories, author. Adding this pattern would be the fastest way to set up a blog as your homepage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs design, or refresh
Status: 🎨 Needs design
Development

No branches or pull requests

5 participants