Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initializeEditor test helper supports Reassure performance tests #49752

Open
dcalhoun opened this issue Apr 12, 2023 · 0 comments
Open

initializeEditor test helper supports Reassure performance tests #49752

dcalhoun opened this issue Apr 12, 2023 · 0 comments
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Dev Ready for, and needs developer efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended

Comments

@dcalhoun
Copy link
Member

What problem does this address?

The native mobile initializeEditor test helper is incompatible with the
recently added Reassure performance testing library. This incompatibility stems
from both Reassure and initializeEditor needing to control the render of the
component tree. In order to simplify writing performance tests for various block
types, we should refactor initializeEditor to support usage with Reassure.

#49221

What is your proposed solution?

An ideal design might resemble the following pseudo code:

await measurePerformance(<InitializeEditor initialHtml={paragraphMarkup} />, {
  scenario: typeWithinParagraph,
});
@dcalhoun dcalhoun added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Apr 12, 2023
@Thelmachido Thelmachido added the Needs Dev Ready for, and needs developer efforts label Apr 12, 2023
@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Dev Ready for, and needs developer efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants