Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top margin of the image block is missing in TT2 #50644

Open
mayuge3 opened this issue May 16, 2023 · 1 comment
Open

Top margin of the image block is missing in TT2 #50644

mayuge3 opened this issue May 16, 2023 · 1 comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@mayuge3
Copy link

mayuge3 commented May 16, 2023

Description

The top margin of the image block is missing in the TT2 front-end view when using the Gutenberg plugin.
It appears that the wp-block-styles (theme.css) is overriding the new global margin #47858.

In the editor, the top margin is available.

Step-by-step reproduction instructions

  1. Create a post and add paragraph and image block.
  2. Check the front-end view.

Screenshots, screen recording, code snippet

Front-end

front front-margin

Editor

editor editor-margin

Environment info

  • WP 6.2
  • Twenty Twenty 2
  • Gutenberg plugin 15.7.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels May 16, 2023
@ndiego
Copy link
Member

ndiego commented May 16, 2023

I was able to replicate this issue as well but it does not occur in WordPress 6.2 without Gutenberg active.

The root issue appears to be related to the fact that TT2 registers the following support: add_theme_support( 'wp-block-styles' ); This was (is) a standard approach, but TT3 is unique in that it does not include a functions.php file, and therefore does not register this support.

I am concerned that this issue might extend beyond just the Image block, so we need to identify what changes were made in Gutenberg that are causing this regression.

@ndiego ndiego added the [Type] Regression Related to a regression in the latest release label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

2 participants