Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkControl: Simpler suggestions #50885

Closed
2 tasks done
richtabor opened this issue May 23, 2023 · 5 comments
Closed
2 tasks done

LinkControl: Simpler suggestions #50885

richtabor opened this issue May 23, 2023 · 5 comments
Assignees
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor

Comments

@richtabor
Copy link
Member

richtabor commented May 23, 2023

Part of #50891

Let's simplify the suggestion display, allowing room for more results and making them a bit easier to digest. Note that suggestions and search result items are programmatically the same.

Tasks

  • Apply proper metrics so that search results have 16px between the contents within each item.
  • Update search-item-type styling ($gray-700, body size, capitalize).

Visuals

Current Proposed
CleanShot 2023-05-23 at 12 20 37 CleanShot 2023-05-23 at 12 13 12
@richtabor richtabor added [Package] Components /packages/components [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels May 23, 2023
This was referenced May 23, 2023
@getdave
Copy link
Contributor

getdave commented May 25, 2023

Remove the search-item-info from each item.

We've been discussing this and I think we should be very careful about regressing the utility of the results in favour of the aesthetics. Not to say you won' have considered this, but rather you may not have the context I've outlined in the comment about the history of why this information was introduced here 🙇

@getdave
Copy link
Contributor

getdave commented May 25, 2023

I'm trying to come up with suggestions for solving this. Maybe a tooltip on hover on a suggestion which shows the URL?

@mirka mirka added [Package] Block editor /packages/block-editor and removed [Package] Components /packages/components labels May 25, 2023
@richtabor
Copy link
Member Author

It may be fine to just include the tail end; not the full URL. i.e. /?page_id=196

@richtabor
Copy link
Member Author

i.e. /?page_id=196

Ironically, this wouldn't be particular useful unless permalinks are set.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 25, 2023
@draganescu draganescu changed the title LinkControl: Simplier suggestions LinkControl: Simpler suggestions May 29, 2023
@richtabor
Copy link
Member Author

Met in the middle with this here. I'll close this.

CleanShot 2023-07-11 at 11 30 41

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor
Projects
Development

No branches or pull requests

4 participants