Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command center: keyboard shortcut inconsistent #51182

Closed
annezazu opened this issue Jun 1, 2023 · 3 comments
Closed

Command center: keyboard shortcut inconsistent #51182

annezazu opened this issue Jun 1, 2023 · 3 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Jun 1, 2023

While testing GB 15.9, I noticed that the command center isn't as consistent in being invoked as it was previously. When editing an individual block, it seems to want to add a link. When no block is selected (or some block combo that's not clear to me), it won't always pop up. I'm not sure what's going on but compared to earlier versions it feels more finicky.

inconsistent.command.k.mov

cc @youknowriad

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 1, 2023
@annezazu
Copy link
Contributor Author

annezazu commented Jun 5, 2023

This was also noted in the FSE Outreach Program Rapid Revamp call for testing:

After adding content to About page and leaving the cursor in a paragraph block, when I click on the CMD + K, not open the command center. In this case, open a Search to add a link (the popup that appears when a link is inserted). I have to click in the parent block to work fine in the command center.

& later:

However, this only works in certain places, see here: https://haurand.com/wp-content/uploads/2023/06/cmd_k.gif
Therefore, I had to search a little until I found a possibility. But actually a cool thing when you have found it.

@youknowriad
Copy link
Contributor

So the fact that it doesn't work when a RichText is focused is actually intended because it's the same shortcut we use for the "link" control. I think the plan is to eventually have commands to add links within the command center, so that we can unify and always trigger the command center when using cmd+k

@youknowriad
Copy link
Contributor

Closing this one in favor of #51737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants