Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default name when adding new colors in styles does not appear in sequential order numbers #51230

Closed
Tracked by #57309
cattmin opened this issue Jun 5, 2023 · 2 comments
Labels
[Feature] Colors Color management Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@cattmin
Copy link

cattmin commented Jun 5, 2023

Description

Using FSE to change styles on a page template. When using the English language in site and add new colors to Styles, the default name appear with numbers in order. However, when switching to Japanese language, the sequential order numbers did not work anymore in the default name.

Step-by-step reproduction instructions

  1. Open the Settings
  2. Change Site Language to Japanese 日本語
  3. Open Site Editor
  4. Click on a template to edit → choose Styles panel on the top right
  5. Click on Colors → Palette
  6. Click on Custom , add button and choose a new color
  7. See that after clicking a new color, the default name is set to the correct sequential order number.
  8. Repeat steps to choose a new color
  9. See that, now the next default name is not set to a sequential order number but repeats the same number as previous.

Screenshots, screen recording, code snippet

issue-report
issue-report

Environment info

  • The site uses WordPress 6.2.2 , Gutenberg 15.9, Twenty Twenty Three theme
  • Reproduced on Firefox 113.0.2 and Chrome Version 114.0.5735.90
    macOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Thelmachido
Copy link

I can replicate this issue.

@Thelmachido Thelmachido added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Colors Color management [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later labels Jun 21, 2023
@t-hamano
Copy link
Contributor

Thanks for the report. This issue has been fixed by #52212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants