Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color value is not displayed in native Cover Block custom color picker #51283

Closed
derekblank opened this issue Jun 7, 2023 · 1 comment
Closed
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.

Comments

@derekblank
Copy link
Member

derekblank commented Jun 7, 2023

What problem does this address?

In the native mobile Cover Block cutom color picker, the color value is not displayed as a text or numerical value when selecting a custom color (Hex, RGB, HSL). For color contrast accessibility reasons, it is helpful to have the value of the color displayed in a text or number format other than the color itself. Adding this value to the native color picker would also match the web behavior, which displays the Hex, RGB, and HSL value of the color selected. We could start with displaying the Hex values first, and the RBG and HSL values could be iterated on later.

What is your proposed solution?

Within the mobile Cover Block custom color picker, display the color value similar to the web behavior and other mobile custom color pickers:

Web Editor (displays hex value) Mobile Editor (is missing hex value)
Screenshot 2023-06-07 at 3 27 57 pm IMG_3023
@derekblank derekblank added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [a11y] Color Contrast labels Jun 7, 2023
@derekblank derekblank self-assigned this Jun 7, 2023
@derekblank derekblank changed the title Color value is not displayed in native color picker Color value is not displayed in native Cover Block custom color picker Jun 15, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 19, 2023
@derekblank
Copy link
Member Author

Completed in #51414.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants