Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site editor: Navigator screens inconsistent icon buttons position and missing tooltip #52590

Closed
afercia opened this issue Jul 13, 2023 · 2 comments · Fixed by #52592
Closed
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 13, 2023

Description

Discovered while investigating #52510

In the navigator screens, some editable objects (e.g. custom templates, custom patterns, pages) show the 'Actions' and 'Edit' icon buttons, in that order. However, for the Navigation menus these icon buttons are inconsistent:

  • The order is reversed.
  • The Actions icon button misses a tooltip.
Screenshot 2023-07-13 at 09 17 34

While the inconsistent order is a design / consistency / usability issue, the missing tooltip is an accessibility issue.

I'd like to remind that any icon button must visually expose its accessible name. Tooltips are required for these buttons. Since there have been several cases of icon buttons with no tooltip (and still there are a few to cover) I'd appreciate a bit more of attention to this requirement from everybody. If education and training turns out to be not enough to make sure icon buttons always have a tooltip, we should consider to make thie behavior automatic and / or implement tests for all icon buttons.

Since this seems a quick and self-contained fix, I'd suggest to consider it for inclusion in the approaching WP 6.3 release.

Step-by-step reproduction instructions

  • Go to the site editor.
  • Observe the order of the buttons and whether they have a tooltip in the following screens:
    • Templates > A custom template.
    • Templates > A default template that hae been customized.
    • Pages > Any page
    • Navigation > Any menu

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [a11y] Labelling labels Jul 13, 2023
@afercia
Copy link
Contributor Author

afercia commented Jul 13, 2023

After more investigation, turns out the Actions button in the Navigation not only misses a tooltip: it misses a lable in the firrst place. One more case of unlabelled control.

@afercia
Copy link
Contributor Author

afercia commented Jul 13, 2023

Is there any way we can make the DropDownMenu label prop required? Cc @ciampo @mirka
Introduced in #50880

<DropdownMenu
className="sidebar-navigation__more-menu"
icon={ moreVertical }
popoverProps={ POPOVER_PROPS }
>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants