Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Add a disclaimer/notice saying the fonts will be downloaded from third-party sources. #53882

Closed
matiasbenedetto opened this issue Aug 22, 2023 · 8 comments
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement.

Comments

@matiasbenedetto
Copy link
Contributor

matiasbenedetto commented Aug 22, 2023

What ?

In the Font Library, the users will be able to download font families from different font collections provided by core or extenders (plugins for example).

Should we add a disclaimer/notice to let the user know the fonts will be downloaded from third-party sites such as Google fonts CDN?

If we should add this notice, we would need a design to implement it into the Font Library frontend.

Context

As a reminder:

  • Font library will display one or more font collections
  • These font collections will present several fonts available to be installed.
  • When the fonts are installed the fonts will be downloaded from the third-party source into /wp-content/uploads/fonts folder and after that, served from it as any other site static asset.

Tracking issue

#53307

@matiasbenedetto matiasbenedetto added Needs Design Needs design efforts. [Feature] Typography Font and typography-related issues and PRs labels Aug 22, 2023
@matiasbenedetto
Copy link
Contributor Author

matiasbenedetto commented Aug 22, 2023

@jasmussen what do you think of this? what could be a good UI/UX to implement this notice?

@jasmussen
Copy link
Contributor

I definitely think it's a good idea. The existing mockups from #45271 have such a notice:

Add fonts from Google, option 1

For legibility, those mockups say:

Add from Google Fonts. Fonts are copied to, and served, from your own server.

If we need to, we can highlight that more:

Add fonts from Google, option 2

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 24, 2023
@jasmussen jasmussen removed the Needs Design Needs design efforts. label Aug 24, 2023
@priethor
Copy link
Contributor

As far as I understand, after talking with @mikachan and @ironprogrammer, there will be a connection to third parties as soon users browse and preview the fonts before downloading them. If so, we should probably adapt the notice to clarify that fact, maybe even before showing the list of fonts?

@jasmussen
Copy link
Contributor

How's this?

The flow is as usual, you click to add fonts, it opens the modal, though the tab is now called "Install Fonts". But now, the first time you visit a big consent box in the middle, where first you have to allow the connection.

Add fonts from Google, option 3

@priethor
Copy link
Contributor

Looks amazing, thanks Joen! That should help dissipate any concerns about connecting to third parties without prior notice.

@matiasbenedetto, is there also a filter to disable online fonts entirely? I'm happy to create an issue for it 🙂

@matiasbenedetto
Copy link
Contributor Author

@matiasbenedetto, is there also a filter to disable online fonts entirely?

If you don't accept the disclaimer you won't make any request for online fonts, so I'm not sure what you mean.

@priethor
Copy link
Contributor

It would be good to have a way to completely turn off online fonts so that the tab with the disclaimer doesn't show at all and users can only upload fonts manually.

@bph bph changed the title Font Library: Add a disclaimer/notice saying the fonts will be downloaded from thrid-party sources. Font Library: Add a disclaimer/notice saying the fonts will be downloaded from third-party sources. Sep 18, 2023
@pbking
Copy link
Contributor

pbking commented Sep 21, 2023

Complete in #54566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants