Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting text within Captions (inline format bar) #541

Closed
mtias opened this issue Apr 28, 2017 · 4 comments · Fixed by #671
Closed

Formatting text within Captions (inline format bar) #541

mtias opened this issue Apr 28, 2017 · 4 comments · Fixed by #671
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone

Comments

@mtias
Copy link
Member

mtias commented Apr 28, 2017

The formatting bar should appear only when you have text added in the caption field, not when you select the block.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 28, 2017
@jasmussen
Copy link
Contributor

For context, it doesn't make sense to select an image block and see "bold" and "italic" options.

But it does make sense to see bold and italic when you have focus on the caption. Ideally we might even show the formatting bar in context of the caption:

image

But barring this, the formatting bar should still only be visible contextual to text.

@mtias mtias added this to the May Week 1 milestone May 1, 2017
@mtias
Copy link
Member Author

mtias commented May 4, 2017

This could be a prop of <Editable inlineToolbar />. Thoughts @youknowriad @iseulde?

@youknowriad
Copy link
Contributor

This could be a prop of <Editable inlineToolbar />

Sounds like a good solution to me 👍

@ellatrix
Copy link
Member

ellatrix commented May 4, 2017

With #660, an alternative could be to show hide the toolbar the some text is focussed.

If not, <Editable inlineToolbar /> sounds good too!

@youknowriad youknowriad self-assigned this May 5, 2017
@mtias mtias changed the title Formatting text within Captions Formatting text within Captions (inline format bar) May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants