Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Listing Navigation "trash" and "delete" actions unexpectedly lead to Site Editor #55082

Open
Tracked by #62680
getdave opened this issue Oct 5, 2023 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Oct 5, 2023

The "trash" and "delete permanently" links in the `wp-admin/edit.php?post_type=wp_navigation" screen take you to the site editor. The only way I could delete the different navigation was to use the bulk actions.

These actions should not go to the Site Editor

Screen.Recording.2023-10-05.at.3.31.08.pm.mp4

I've also noticed that. I think those actions shouldn't open the Site Editor. But I'm guessing they're both using _edit_link as a path, so we get this behavior.

Here's the core sync PR for that change - WordPress/wordpress-develop#4710. Maybe @ramonjd or @getdave have ideas on how to fix it.

Originally posted by @Mamaduka in #55072 (comment)

@getdave getdave added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Oct 5, 2023
@ramonjd
Copy link
Member

ramonjd commented Oct 6, 2023

Hi folks! Thanks for creating this issue.

This is something I suspect we'd need to resolve in Core. Namely, how to return different edit links based on context, or the referring URL params or 🤷🏻

I've had a Core Tract ticket up for while to get discussion going around this issue:

It's growing cobwebs.

@noisysocks
Copy link
Member

Ran into this as well while testing.

Kapture.2024-06-04.at.12.11.07.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants