Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Quick-actions #55096

Closed
jameskoster opened this issue Oct 5, 2023 · 10 comments · Fixed by #55488
Closed

Table: Quick-actions #55096

jameskoster opened this issue Oct 5, 2023 · 10 comments · Fixed by #55488
Assignees
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

This ticket is a stub to include designs for quick-actions in table views.

"Quick-actions" include things like moving pages to the trash, or reseting a template. Additionally, they can potentially encapsulate much of the "quick edit" affordance on wp-admin tables, IE enabling users to edit post meta without engaging the full-screen editor.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. labels Oct 5, 2023
@annezazu annezazu added the [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond label Oct 9, 2023
@youknowriad
Copy link
Contributor

Where are we on the design aspect here? I wanted to start looking at this soon.

@jameskoster
Copy link
Contributor Author

@youknowriad the latest work includes quick-actions at the end of each row. They are split into two categories; Primary and Secondary. Primary actions are displayed permanently, and secondary actions are grouped in an overflow menu.

quick-actions.mp4

For Pages the primary actions would be 'View' and 'Trash'. The full list of secondary actions (and their associated UIs) needs to be decided upon, but potentially we can include 'Edit' and 'View revisions' straight away as there are clear destinations for each.

Screenshot 2023-10-16 at 10 31 23

For templates, the primary action(s) would be 'Trash/Reset' where applicable. Secondary actions would be 'Edit', 'View revisions', and 'Rename' for custom templates.

Screenshot 2023-10-16 at 10 36 48

In both cases there might be an argument to make 'Edit' a primary action, depending on the behavior we settle on for clicking the document title (edit vs. view details).

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Oct 16, 2023
@youknowriad
Copy link
Contributor

@jameskoster Makes sense, how do these actions translate/render in the "grid view"?

@jameskoster
Copy link
Contributor Author

It would be nice to include actions in the same format if possible. Whether they appear adjacent to / beneath the title, overlayed on the thumbnail, or something else will likely depend on how other fields are handled in that view mode. I suspect this will require a dedicated exploration to get right.

@ntsekouras
Copy link
Contributor

@jameskoster the view quick action will point to the front end or the site editor in 'view' mode?

@jameskoster
Copy link
Contributor Author

The frontend. It's the same functionality as the "View" link in the current pages list in wp-admin.

@ntsekouras
Copy link
Contributor

First iteration landed, so it would be good to update this issue with more specific action items, or create a new one.

@ntsekouras ntsekouras reopened this Oct 25, 2023
@jameskoster
Copy link
Contributor Author

@ntsekouras with the foundations in place I reckon we can close this and open issues for different contexts (pages, templates). I'll open those asap.

One small detail you may want to address until then: The 'Edit' action should go directly into the editor rather than the details view.

@ntsekouras
Copy link
Contributor

ntsekouras commented Oct 26, 2023

One small detail you may want to address until then: The 'Edit' action should go directly into the editor rather than the details view.

@jameskoster what do you mean by that?

--edit

Actually I probably get what you mean. There could be a race condition there and sometimes redirects you to the details view. I'll take a look at it.

@jameskoster
Copy link
Contributor Author

Just to clarify, the behavior should essentially match the wp-admin 'Edit' link, which takes you directly to the editor (no details view interstitial).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants