Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block mover: disabled buttons should be disabled #575

Closed
afercia opened this issue Apr 29, 2017 · 2 comments
Closed

Block mover: disabled buttons should be disabled #575

afercia opened this issue Apr 29, 2017 · 2 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Apr 29, 2017

Currently, when a block is the first or last one, the "block mover" shows just one button to move the block down or up.

However, the "disabled" button is still there: it gets revealed on hover and it's still focusable and actionable. It just takes a CSS class that applies a close-to-white color, so it can't be distinguished from the white background:

screen shot 2017-04-29 at 18 34 24

It should probably use display: none or visibility: hidden if keeping the space that it takes is necessary for layout purposes. I'd consider to make it really disabled too.

@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label May 1, 2017
@mtias mtias added Good First Issue An issue that's suitable for someone looking to contribute for the first time Framework Issues related to broader framework topics, especially as it relates to javascript labels May 1, 2017
@nylen
Copy link
Member

nylen commented May 1, 2017

It should probably use display: none or visibility: hidden if keeping the space that it takes is necessary for layout purposes. I'd consider to make it really disabled too.

I think it's nice to leave the buttons visible to indicate that they would be active if not for some condition being true.

@afercia
Copy link
Contributor Author

afercia commented May 1, 2017

Yep that also could work 🙂 visually disabled and with a disabled attribute.

@nylen nylen closed this as completed in #588 May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants