Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using a full page for the font management #57904

Open
carolinan opened this issue Jan 17, 2024 · 3 comments
Open

Try using a full page for the font management #57904

carolinan opened this issue Jan 17, 2024 · 3 comments
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@carolinan
Copy link
Contributor

carolinan commented Jan 17, 2024

What problem does this address?

The font library currently uses a modal with tabs and tabs panels. In the view where you select from Google fonts, an infinite scroll is used. There are both accessibility and usability problems with this.

  • As already reported, the focus is incorrect when the content inside the tab panel changes:
    #54431
  • it is not currently possible to open the modal in any other way than using the "manage fonts" button in the typography panel in the global styles sidebar. This now blocks tasks like [adding a command to open the fonts]
    (Command Palette: add command to open fonts #54880). If this was handled as a separate page inside the Site Editor that could be navigated to, this would not be an issue.
  • The infinite scroll is difficult to use, and this pattern has been discussed and has already been removed from other screens in WordPress. It should be avoided. Core trac #40330
  • Even without the infinite scroll, a modal is not suitable for presenting this amount of content. You can also compare the size of the current font management modal and the media library modal. -At least with the media library the users has more than one option of where to manage their files.
  • A full page has already been successfully used in the "Create block theme" plugin.

What is your proposed solution?

Create a rough draft with the font management as a Site Editor page so that the experiences can be compared and user tested.

@carolinan carolinan added [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. labels Jan 17, 2024
@colorful-tones
Copy link
Member

I do wonder how we landed on a modal. 🤔

It might be worth exploring this through design and would likely require punting the Font Library rollout to another major release. However, let's do it once, and do it right 😄

@jasmussen
Copy link
Contributor

The modal offers access to a detailed preview of managing and installing fonts, one that is available from within the edit view letting you stay in the design flow, but also potentially invokeable from other flows such as a plugin that adds a font source tab, or from a context in the edit view. As a silo for your font files, this is meant to resemble the media library flow (a silo for your media files), and is something that can be useful in a variety of contexts. You can dive into the history in this issue from a while back.

@carolinan
Copy link
Contributor Author

The media library can be managed from more than one place, the fonts can't. It also does not match the size of the media library modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Development

No branches or pull requests

3 participants