Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Buttons within the Fonts modal dialog should use the new buttons height #58374

Closed
afercia opened this issue Jan 29, 2024 · 1 comment · Fixed by #58421
Closed
Assignees
Labels
[Feature] Font Library Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 29, 2024

Description

The height of the buttons within the Fonts modal dialog is 36 pixels. Screenshot:

Screenshot 2024-01-29 at 12 36 02

Shouldn't all new UIs use the new 40 pixels buttons height? Cc @WordPress/gutenberg-design

Buttons in other modal dialogs already use the 40 pixels height e.g. in the "Duplicate pattern" modal dialog:

Screenshot 2024-01-29 at 12 38 43

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Feature] Font Library labels Jan 29, 2024
@t-hamano
Copy link
Contributor

Shouldn't all new UIs use the new 40 pixels buttons height?

As far as #46741 goes, I think that's correct. Some related PRs have already been merged as well.

https://github.com/WordPress/gutenberg/pulls?q=is%3Apr+is%3Amerged+in%3Atitle+__next40pxDefaultSize+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants