Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmdk to latest version and remove temporary fix from PR 56718 #59703

Closed
afercia opened this issue Mar 8, 2024 · 0 comments · Fixed by #63465
Closed

Update cmdk to latest version and remove temporary fix from PR 56718 #59703

afercia opened this issue Mar 8, 2024 · 0 comments · Fixed by #63465
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Commands /packages/commands [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Mar 8, 2024

Description

Latest cmdk release incorporated a fix for the 'suggestions list' and 'loading progressbar' labels we were waiting for.
Changelog: https://github.com/pacocoursey/cmdk/releases/tag/v1.0.0
Fix: pacocoursey/cmdk#204

While waiting for this upstream fix we introduced a temporary workaround in #56718 that can be removed after updating the cmdk package and by passing the new two label props. Note we have to pass both new labels because we want them to be translatable.

Cc @youknowriad

Temporary workaround to be removed:

// Temporary fix for the suggestions Listbox labeling.
// See https://github.com/pacocoursey/cmdk/issues/196
useEffect( () => {
commandListRef.current?.removeAttribute( 'aria-labelledby' );
commandListRef.current?.setAttribute(
'aria-label',
__( 'Command suggestions' )
);
}, [ commandListRef.current ] );

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Commands /packages/commands labels Mar 8, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Commands /packages/commands [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants