Update cmdk
to latest version and remove temporary fix from PR 56718
#59703
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Package] Commands
/packages/commands
[Status] In Progress
Tracking issues with work in progress
[Type] Enhancement
A suggestion for improvement.
Description
Latest
cmdk
release incorporated a fix for the 'suggestions list' and 'loading progressbar' labels we were waiting for.Changelog: https://github.com/pacocoursey/cmdk/releases/tag/v1.0.0
Fix: pacocoursey/cmdk#204
While waiting for this upstream fix we introduced a temporary workaround in #56718 that can be removed after updating the
cmdk
package and by passing the new two label props. Note we have to pass both new labels because we want them to be translatable.Cc @youknowriad
Temporary workaround to be removed:
gutenberg/packages/commands/src/components/command-menu.js
Lines 209 to 217 in 985ea06
Step-by-step reproduction instructions
N/A
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: