Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Extract notices state from editor module #6388

Closed
aduth opened this issue Apr 24, 2018 · 2 comments
Closed

Framework: Extract notices state from editor module #6388

aduth opened this issue Apr 24, 2018 · 2 comments
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Type] Enhancement A suggestion for improvement. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone

Comments

@aduth
Copy link
Member

aduth commented Apr 24, 2018

Notices are not an editor-specific feature, yet the current notices state lives within editor. Before plugins start integrating more with this functionality, we should consider whether to extract it, either to its own module (like viewport), or to components, or perhaps even to a new concept of "data-bound components".

See also #5316 which highlights some issues with the viewport approach of independent data modules exporting their own components, as it can result in circular dependencies between components and the individual module.

Proposal options:

  • Create new notices folder, which creates its own data state
    • Either exposes a data-bound component which editor uses to render, or this component lives elswhere
  • Add new notices component to components directory, which bundles its own data state

Open questions:

Do we need concepts of scoped notices? If a plugin adds a notice and intends for it to be shown in the editor, how does this scale out to a more general solution? Is this something we need to address now?

@aduth aduth added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Apr 24, 2018
@danielbachhuber
Copy link
Member

Some relevant prior issues:

@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Oct 10, 2018
@danielbachhuber danielbachhuber added the Backwards Compatibility Issues or PRs that impact backwards compatability label Oct 10, 2018
@danielbachhuber danielbachhuber added [Type] Enhancement A suggestion for improvement. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. labels Oct 10, 2018
@gziolo gziolo modified the milestones: WordPress 5.0, API Freeze Oct 22, 2018
@collimarco
Copy link

This issue has been closed, but traditional admin_notices don't work in Gutenberg (they are not displayed...)

Please fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Type] Enhancement A suggestion for improvement. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

4 participants