Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reusable block actions in lieu of @wordpress/core-data methods #7011

Closed
noisysocks opened this issue May 30, 2018 · 3 comments
Closed

Remove reusable block actions in lieu of @wordpress/core-data methods #7011

noisysocks opened this issue May 30, 2018 · 3 comments
Assignees
@noisysocks
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
WordPress 5.x

Comments

@noisysocks
Copy link
Member

noisysocks commented May 30, 2018 •
edited
Loading

We should be able to remove fetchReusableBlocks(), updateReusableBlocks(), etc. and instead use the built-in @wordpress/core-data methods e.g. getEntityRecord() and updateEntityRecord().

This came up in #6067 and again in #6753 (comment).

Blocked on #7119.
@noisysocks noisysocks added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels May 30, 2018
@noisysocks noisysocks added this to the Merge Proposal: Editor milestone May 30, 2018
@noisysocks noisysocks mentioned this issue May 30, 2018
Merged
@mtias
Copy link
Member

mtias commented Jul 19, 2018

Is this going to be part of the refactoring? #7453

@noisysocks
Copy link
Member Author

I plan on doing this after #7453 lands as the refactoring will make it a whole lot simpler.

@noisysocks noisysocks self-assigned this Jul 20, 2018
@mtias mtias modified the milestones: Merge: Editor, WordPress 5.0 Oct 12, 2018
@noisysocks noisysocks changed the title Remove fetchSharedBlocks() in lieu of a data resolver Remove reusable block actions in lieu of a @wordpress/core-data methods Nov 5, 2018
@noisysocks noisysocks changed the title Remove reusable block actions in lieu of a @wordpress/core-data methods Remove reusable block actions in lieu of @wordpress/core-data methods Nov 5, 2018
@noisysocks
Copy link
Member Author

Closing this as it is a subset of #11124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisysocks noisysocks

Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
WordPress 5.x
Development

No branches or pull requests
2 participants
@mtias @noisysocks