Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns Block (beta): sibling inserters don't work within the columns block #7920

Closed
maddisondesigns opened this issue Jul 12, 2018 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@maddisondesigns
Copy link

Describe the bug
None of the Block Inserters work on the Column Block. It's impossible to add a Block above a Column Block and it's also impossible to insert blocks into the column block itself

gutenberg_columnblockblockinsertersdontwork

To Reproduce
Steps to reproduce the behavior:

  1. Add Column Block
  2. Add multiple Paragraph Blocks into the Column Block
  3. Try to insert a Block above the Column Block
  4. Try to insert another Paragraph Block above the top Paragraph Block

Expected behavior
Block inserters should work and should be easier to click

macOS Sierra 10.12.1
Firefox Quantum 61.0.1 (64-bit)
Gutenberg 3.2.0

@designsimply designsimply added [Feature] Blocks Overall functionality of blocks [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Jul 19, 2018
@designsimply designsimply changed the title Block Inserters on Column Block dont work Columns Block (beta): sibling inserters don't work within the columns block Jul 19, 2018
@designsimply
Copy link
Member

Closing because I tested with WordPress 4.9.7 and Gutenberg 3.2.0 using Firefox 61.0.1 on macOS 10.13.6 and found that the block inserters within the columns block work for me. (45s)

#7766 should address the problem described about not being able to select the whole columns block.

Related note: the inserters are not present when a block is selected and I believe that is by design. I noticed in your video that you tried to find an inserter on the 2nd paragraph block after clicking on the content which will not work with the way inserters are currently designed to work—I am not sure if that will change and it is a different issue/discussion but helpful to know when testing here.

@chrisvanpatten
Copy link
Member

chrisvanpatten commented Jul 19, 2018

@designsimply I can reproduce this in Safari 11.1.1 and I think it might be related to #7642.

Scratch that. It's working inconsistently now and I think it might actually be related to #7766.

@maddisondesigns
Copy link
Author

@designsimply @chrisvanpatten Can you please reopen this. The sibling inserters still don't work properly. Here's another gif I just created. Out of about a dozen clicks I was only able to get the inserter to work once.

Not only that, when it doesn't work, it simply selects the block and shows the toolbar. You then have to click outside of the block to deselect it because the sibling inserter wont even display when the block is selected because it's hidden by the toolbar. It shouldn't be this hard for users to add content into multiple columns.

gutenberg_columnssiblinginsertersdontwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

3 participants