Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Link UI open upon initial link creation when used in RichText #57726

Merged
merged 17 commits into from
Jan 24, 2024
Merged

Keep Link UI open upon initial link creation when used in RichText #57726

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
485cc81
Don’t clear activeFormats on submit
getdave Jan 10, 2024
a457c48
Expose API to allow triggering the anchor to be recomputed
getdave Jan 10, 2024
2b055be
Correctly position Popover on link creation and avoid focus shifts du…
getdave Jan 10, 2024
954c946
Add privateApis to RichText package and export useAnchorWithUpdate hook
getdave Jan 12, 2024
343c735
Consume new private API in Link UI
getdave Jan 12, 2024
306bf38
Fix docs
getdave Jan 12, 2024
0f5202b
Revert "Add privateApis to RichText package and export useAnchorWithU…
getdave Jan 12, 2024
25ffdf7
Fix anchor position using standardised method
getdave Jan 12, 2024
91a766a
Revert all changes to useAnchor hook
getdave Jan 12, 2024
011fe3b
Remove changing selection when commiting new links
getdave Jan 12, 2024
a20eace
Add more detail to comment
getdave Jan 23, 2024
10858fa
Fix e2e test: can be created and modified using only the keyboard
jeryj Jan 23, 2024
fb8f5a9
Test e2e fix: can update the url of an existing link
jeryj Jan 23, 2024
4892384
Fix e2e test: toggle state of advanced link settings is preserved acr…
jeryj Jan 23, 2024
28062a3
Test e2e fix createAndReselectLink util
jeryj Jan 23, 2024
b94bdec
Fix e2e test: should not show the Link UI when selection extends beyo…
jeryj Jan 23, 2024
ebfba2d
e2e test fix: should not show the Link UI when selection extends into…
jeryj Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/e2e/specs/editor/blocks/links.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,11 +445,13 @@ test.describe( 'Links', () => {
await pageUtils.pressKeys( 'Enter' );

const linkPopover = LinkUtils.getLinkPopover();
await expect( linkPopover ).toBeVisible();
// Close the link control to return the caret to the canvas
await pageUtils.pressKeys( 'Escape' );

// Deselect the link text by moving the caret to the end of the line
// and the link popover should not be displayed.
await pageUtils.pressKeys( 'End' );
await expect( linkPopover ).toBeHidden();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we invert this instead? toBeVisible()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to do a little bit more, since the focus is in a different spot. I modified it to match the spirit of what the test was already testing. fb8f5a9


// Move the caret back into the link text and the link popover
// should be displayed.
Expand Down
Loading